Add mapping of untyped nil args to BindNull to exec docs#122
Merged
zombiezen merged 2 commits intozombiezen:mainfrom Jul 2, 2025
Merged
Add mapping of untyped nil args to BindNull to exec docs#122zombiezen merged 2 commits intozombiezen:mainfrom
BindNull to exec docs#122zombiezen merged 2 commits intozombiezen:mainfrom
Conversation
zombiezen
reviewed
Jul 1, 2025
Owner
zombiezen
left a comment
zombiezen
left a comment
There was a problem hiding this comment.
Sorry to leave you hanging for so long. I'm not sure how this slipped through the cracks on my end. A few minor tweaks, please:
Contributor
Author
|
Thanks for the review @zombiezen. I've updated the PR and fixed the inconsistent spacing (tabs/spaces). This is what it looks like now when rendered: 
I updated the Let me know if any thing else needs adjusting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my app, values passed in from JSON (and elsewhere) where they could be a value or
NULLin SQL are stored as typed pointers, such as*string. In order to ensure these are handled bysqlitexand bound asBindNull, thenilvalue needs to be passed as an untyped nil, rather than a*stringThis needs to be handled on my side so this PR documents the handling of untyped nil to BindNull in the
ExecOptionsdocumentation, alongside how other types are handled.This also slightly adjusts the default handling documentation, so each section mentions
fmt.Sprint(v)and aligns with the implementation (https://github.com/zombiezen/go-sqlite/blob/main/sqlitex/exec.go#L327).